Add methods to create a parameter client in Node#75
Merged
Conversation
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
ivanpauno
force-pushed
the
ivanpauno/parameters-client
branch
from
f54eb63 to
8beba78
Compare
Collaborator
Author
|
Depends on #74. |
jacobperron
approved these changes
Jun 1, 2021
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
I would rather have only one
ParametersClientclass that has both sync and async methods, though it doesn't matter much.
Having a single client makes sense to me. I guess we can leave it for now, which keeps it similar to rclcpp.
jacobperron
pushed a commit
to ros2-java/ros2_java
that referenced
this pull request
May 17, 2022
* Cleanup service/client creation code Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com> * Add methods to create a parameter client in Node Signed-off-by: Ivan Santiago Paunovic <ivanpauno@ekumenlabs.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both classes are almost equivalent to the ones in
rclcpp, the existing code also already had unit tests.I think that it doesn't make much sense to have separated
AsyncParametersClientandSyncParametersClientimplementations, as the internal implementations is almost the same.I would rather have only one
ParametersClientclass that has both sync and async methods, though it doesn't matter much.